test(contracts): improve DisputeMonitorHelper test coverage #18732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(contracts): improve DisputeMonitorHelper test coverage
Summary
Enhances the
DisputeMonitorHelpertest suite by converting focused tests to fuzz tests and adding edge case coverage:0x0) and fuzz test verifying output prefix formattest_search_olderThanEverything_succeedsandtest_search_newerThanEverything_succeedsto proper fuzz tests with bounded timestamp parameterstest_getUnresolvedGames_betweenTimestamps_succeedsto fuzz test with parameterized timestamps and gapThe original tests used
vm.randomUint()internally but weren't parameterized fuzz tests. Converting them to proper fuzz tests withbound()constraints provides broader coverage across the input space.Review & Testing Checklist for Human
type(uint64).max - 1for newer search to allow +1 without overflow)just test-dev --match-path test/periphery/monitoring/DisputeMonitorHelper.t.sol -vto confirm all 16 tests passNotes