Remove base from contract version check exclusions + tidy up L2OutputOracle validation exclusions (#359)

* remove base from contract version check exclusions

* Tidy up exclusions for L2OutputOracle validation checks (#360)

* skip l2oo checks for any fault proof chain

* slacken challenge_period_seconds requirement on sepolia superchain

* remove several l2oo exclusions

* add clarifying comments

Author: geoknee

superchain/configs/mainnet/base.yaml

@@ -6,8 +6,9 @@ explorer: https://explorer.base.org
 
 superchain_level: 1
 standard_chain_candidate: true # This is a temporary field which causes most of the standard validation checks to run on this chain
-
 superchain_time: 0 # Missing hardfork times are inherited from superchain.yaml
+contracts_version_tag: op-contracts/v1.3.0 # Multi-Chain Prep (MCP) https://github.com/ethereum-optimism/optimism/releases/tag/op-contracts%2Fv1.3.0
+
 
 system_config_addr: "0x73a79Fab69143498Ed3712e519A88a918e1f4072"
 batch_inbox_addr: "0xFf00000000000000000000000000000000008453"

validation/exclusions_test.go

@@ -27,12 +27,8 @@ var exclusions = map[string]map[uint64]bool{
 		11763072: true, // sepolia-dev-0/base-devnet-0     (no public endpoint)
 	},
 	"L2OO_Params": {
-		10:        true, // OP mainnet - Upgraded to fault proofs
-		999999999: true, // sepolia/zora  Incorrect finalizationPeriodSeconds, 604800 is not within bounds [12 12]
-		1740:      true, // sepolia/metal Incorrect finalizationPeriodSeconds, 604800 is not within bounds [12 12]
-		919:       true, // sepolia/mode  Incorrect finalizationPeriodSeconds, 180 is not within bounds [12 12]
-		11155420:  true, // sepolia/op No L2OO because this chain uses Fault Proofs https://github.com/ethereum-optimism/superchain-registry/issues/219
-		11155421:  true, // oplabs-sepolia-devnet-0 No L2OO because this chain uses Fault Proofs https://github.com/ethereum-optimism/superchain-registry/issues/219
+		11155421: true, // sepolia-dev-0/oplabs-devnet-0 (does not yet declare a contract versions tag)
+		11763072: true, // sepolia-dev-0/base-devnet-0  (does not yet declare a contract versions tag)
 	},
 	"L1_Security_Config": {
 		8453:      true, // base (incorrect challenger, incorrect guardian)
@@ -57,7 +53,6 @@ var exclusions = map[string]map[uint64]bool{
 		11763072: true, // sepolia-dev-0/base-devnet-0     No Public RPC declared
 	},
 	"Standard_Contract_Versions": {
-		8453:     true, // mainnet/base
 		11155421: true, // sepolia-dev-0/oplabs-devnet-0
 		11763072: true, // sepolia-dev-0/base-devnet-0
 	},

validation/l2oo_test.go

@@ -26,6 +26,10 @@ type L2OOParams struct {
 func testL2OOParams(t *testing.T, chain *ChainConfig) {
 	skipIfExcluded(t, chain.ChainID)
 
+	if *chain.ContractsVersionTag == "op-contracts/v1.4.0" {
+		t.Skip("Chain is on fault proofs, so there is no L2OutputOracle to track")
+	}
+
 	rpcEndpoint := Superchains[chain.Superchain].Config.L1.PublicRPC
 
 	require.NotEmpty(t, rpcEndpoint)

validation/standard/standard-config-params-sepolia.toml

@@ -10,7 +10,7 @@ maximum_base_fee = "340_282_366_920_938_463_463_374_607_431_768_211_455"
 [l2_output_oracle]
 submission_interval = [1, 86400]
 l2_block_time = [2, 2]
-challenge_period_seconds = [12, 12] # i.e. finalization period
+challenge_period_seconds = [12, 604800] # i.e. finalization period
 
 [gas_price_oracle.pre-ecotone]
 decimals = [6, 6]