-
Notifications
You must be signed in to change notification settings - Fork 200
Celo-sepolia #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Celo-sepolia #1099
Conversation
…in chainList files
bitwiseguy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments which should fix incorrect values and get the ci to pass (after your commit just codegen changes you create locally and push to this pr)
| @@ -0,0 +1,66 @@ | |||
| name = "Celo Sepolia" | |||
| public_rpc = "" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please populate this value, then re-run just codegen $SEPOLIA_RPC_URL to propagate the value into codegen'd files.
| sequencer_rpc = "https://forno.celo-sepolia.celo-testnet.org" | ||
| explorer = "https://celo-sepolia.blockscout.com" | ||
| superchain_level = 2 | ||
| governed_by_optimism = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set this to false, then re-run just codegen $SEPOLIA_RPC_URL to propagate the value into codegen'd files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file from the pr so it is not committed to the repo
|
Hey @pahor167 I see unexpected changes in the files and you have ran just sync staging yourself while it was meant for us maintainers to run. Can you please open a new PR where you just add the files in staging? Thank you! |
Adding a New Chain
This PR adds [Chain Name Here] to the registry.
Checklist
just codegen $SEPOLIA_RPC_URL,$MAINNET_RPC_URLto ensure that all auto-generated files are updatedAllow edits from maintainerson this PR.