-
Notifications
You must be signed in to change notification settings - Fork 200
Binary testnet holocene timestamp added #749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
priyanshuthapliyal55
wants to merge
18
commits into
ethereum-optimism:main
Choose a base branch
from
priyanshuthapliyal55:binary-testnet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
838e4d1
binary mainnet addition to Superchain
6c3fbbc
Merge branch 'main' into binary-mainnet
sbvegan a70b4c1
Merge branch 'main' into binary-mainnet
sbvegan 43fac51
Merge branch 'main' into binary-mainnet
sbvegan 47a4faf
Merge branch 'main' into binary-mainnet
sbvegan 22ef022
Resolved merge conflicts
30096ed
timestamp added
daa175e
right timestamp for fjord
939933e
few changes
f92d029
Merge branch 'main' into binary-mainnet
priyanshuthapliyal55 45fe327
updating with main branch updates
43c0344
Merge branch 'ethereum-optimism:main' into main
priyanshuthapliyal55 8becbf4
binary testnet added
3d793bc
Merge branch 'ethereum-optimism:main' into main
priyanshuthapliyal55 d5a48cf
Merge branch 'ethereum-optimism:main' into main
priyanshuthapliyal55 2fa11df
Holocene timestamp added
priyanshuthapliyal55 d940593
Update superchain/configs/sepolia/tbn.toml
priyanshuthapliyal55 4b34325
Merge branch 'main' into binary-testnet
priyanshuthapliyal55 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,9 @@ batch_inbox_addr = "0xFf00000000000000000000000000000000042069" | |
| canyon_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||
| delta_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||
| ecotone_time = 0 # Thu 1 Jan 1970 00:00:00 UTC | ||
| fjord_time = 1723204838 #Saturday June 8 2024 10:47:18 AM UTC | ||
| granite_time = 1723545055 #Monday June 12 2024 1:57:35 PM UTC | ||
| fjord_time = 1723204838 # Fri Aug 09 2024 12:00:38 UTC | ||
| granite_time = 1723545055 # Tue Aug 13 2024 10:30:55 UTC | ||
|
Comment on lines
+11
to
+12
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. verified that the timestamps in the corrected comments are ✅ |
||
| superchain_time = 1732633200 # Holocene - Tue Nov 26 15:00:00 UTC 2024 | ||
| block_time = 2 | ||
| seq_window_size = 3600 | ||
| max_sequencer_drift = 600 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that these timestamp comments incorrect before -- @bitwiseguy do we know why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old ones look like they were created manually, not with
date -u -r.