Skip to content

Update EIP-684: fix grammar in eip 684 #10115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update EIP-684: fix grammar in eip 684 #10115

wants to merge 1 commit into from

Conversation

RenanSouza2
Copy link
Contributor

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@RenanSouza2 RenanSouza2 requested a review from eth-bot as a code owner August 6, 2025 20:54
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core labels Aug 6, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Aug 6, 2025 •
edited
Loading

File EIPS/eip-684.md

Requires 1 more reviewers from @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Aug 6, 2025
@eth-bot eth-bot changed the title fix grammar in eip 684 Update EIP-684: fix grammar in eip 684 Aug 6, 2025
g11tech
g11tech approved these changes Aug 9, 2025
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @SamWilsn might require force merge here

@poojaranjan poojaranjan mentioned this pull request Aug 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g11tech g11tech g11tech approved these changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

+1 more reviewer

@Cassieminkus1 Cassieminkus1 Cassieminkus1 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RenanSouza2 @eth-bot @g11tech @Cassieminkus1