Pass max_blobs_per_block into Engine API methods
#4042
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
approved these changes
Dec 10, 2024
Contributor
g11tech
left a comment
g11tech
left a comment
There was a problem hiding this comment.
i guess this is sort of needed as many other places EL tends to use the current max (to not get DOS-ed by the tx, to prune the versioned hashes to blob map)
lgtm
16 tasks
Member
Author
|
An update from client testing call 16:
So we are going to wait to merge this PR until we've decided what the right approach is. |
Member
Author
|
Closing in favor of #4046. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on Discord here. We might need to pass
max_blobs_per_block(not justtarget_blobs_per_block) to the EL. Without it, the EL is unable to do certain tasks (egeth_feeHistory) due to a lack of information. This is a follow up to: