Add payload_status field to AttestationData#4655
Closed
mehdi-aouadi wants to merge 3 commits intoethereum:masterfrom
Closed
Add payload_status field to AttestationData#4655mehdi-aouadi wants to merge 3 commits intoethereum:masterfrom
payload_status field to AttestationData#4655mehdi-aouadi wants to merge 3 commits intoethereum:masterfrom
Conversation
jtraglia
reviewed
Oct 17, 2025
specs/gloas/beacon-chain.md
Outdated
| # Removed index | ||
| beacon_block_root: Root | ||
| # [New in Gloas:EIP7732] | ||
| payload_status: PayloadStatus |
Member
There was a problem hiding this comment.
Since PayloadStatus is not an SSZ type, I think it would be better to rename the field and use a boolean.
Maybe payload_present or payload_revealed (not sure which is better):
Suggested change
| payload_status: PayloadStatus | |
| payload_revealed: boolean |
Contributor
Author
There was a problem hiding this comment.
In the end I just renamed the index field to payload_status and kept the uint64 type to avoid impacting the SSZ serialisation. Plus it would be possible to introduce new statuses if needed in the future...
c45158a to
650bf98
Compare
650bf98 to
739b193
Compare
payload_status field to AttestationData
18 tasks
Contributor
Author
|
Closing this PR since it was discussed during EIP-7732 Breakout Room Call #26 and the majority preferred implementation stability and judged this change complex to implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a structural clarification to the
AttestationDatacontainer by renaming theindexfield topayload_status. This field has been unused for its original purpose (committee index designation) since the Electra upgrade and is now repurposed to explicitly signal the status of the execution payload of the attested-to block. The underlyinguint64type is retained to ensure structural stability and provide extensibility for future payload statuses.The continued existence of
the attestation_data.indexfield in its legacy form presents several issues:Risk: Any modification to AttestationData can have wide-ranging and subtle effects.
Mitigation: This change is strictly a rename and does not alter the size, SSZ structure, or serialisation of the container. By avoiding a type change (e.g., to an enum), we minimise the scope of downstream code changes and reduce the risk of introducing new bugs.
Related Links
Context: EIP-7732 Breakout Call #25
Discussion: Discord Thread on Ethereum R&D