Reduce SSZ test vector size#4662
Merged
jtraglia merged 2 commits intoethereum:masterfrom Oct 20, 2025
Merged
Conversation
Contributor
Author
|
Also fixes the ram issue @jtraglia Before: After: |
Member
|
Thanks @etan-status! I will approve/merge this if it works here: |
Member
|
Restarted the reference test generation action with some logging improvements: |
Limit lists in SSZ tests to 1500 items instead of 2000 to lower size of test vectors. Further focus on testing edge cases rather than having an exhaustive test for all possible unsupported CompatibleUnion options. 1500 items still covers the same tree shapes, as in, it is: - between 1024 and 2047 for the regular trees - between 1365 and 5460 for progressive trees For progressive tree cutoffs see table here: - https://eips.ethereum.org/EIPS/eip-7916#progressive-merkle-tree)
etan-status
force-pushed
the
sz-maxitems
branch
from
649c448 to
2b072d1
Compare
jtraglia
approved these changes
Oct 20, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
These changes look fine to me, but we're going to need to refactor the SSZ tests in the future. Leo and I agree that the fuzzy approach to this is less than ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit lists in SSZ tests to 1500 items instead of 2000 to lower size of
test vectors. Further focus on testing edge cases rather than having an
exhaustive test for all possible unsupported CompatibleUnion options.
1500 items still covers the same tree shapes, as in, it is:
For progressive tree cutoffs see table here: