Add manifest file to each each reference test#4712
Merged
leolara merged 6 commits intoethereum:masterfrom Dec 4, 2025
Merged
Conversation
Contributor
Author
|
Hi @leolara , Please help review the changes made to this issue |
Member
|
@Sandijigs check the produced manifest.yaml It should not look like that, but like the data.yaml for example |
Contributor
Author
|
Okay @leolara |
Member
|
@Sandijigs are you doing it? |
Contributor
Author
|
yes , @leolara . I am currently on it , |
… and test cases easier to share and verify
block style instead of flow style
b375022 to
15e12eb
Compare
leolara
reviewed
Nov 24, 2025
leolara
approved these changes
Nov 24, 2025
Member
|
LGTM 🚀 I would perhaps change the README, to indicate that the directory structure is the legacy style of figuring out this data. |
leolara
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes Made
make lintto check formattingmake testto check testsFixes #4602