Use proper integer encoding for Union in SSZ#4725
Merged
jtraglia merged 1 commit intoethereum:masterfrom Nov 11, 2025
Merged
Conversation
From "Integers are encoded as strings", it follows that the numeric "selector" of `Union` should also be encoded like that. Note that `Union`'s JSON encoding is currently unused. Portal uses it only for binary serialization.
kdeme
approved these changes
Nov 5, 2025
kdeme
left a comment
kdeme
left a comment
There was a problem hiding this comment.
lgtm, Portal has SSZ Union usage in Portal wire protocol, but nowhere does/uses JSON encoding of those Unions.
jtraglia
approved these changes
Nov 5, 2025
konginit
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From "Integers are encoded as strings", it follows that the numeric "selector" of
Unionshould also be encoded like that. Note thatUnion's JSON encoding is currently unused. Portal uses it only for binary serialization.