Suggest to queue DataColumnSidecars if they race the block #4736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
reviewed
Nov 11, 2025
|
|
||
| - _[IGNORE]_ The sidecar's `beacon_block_root` has been seen via a valid signed | ||
| execution payload header (builder's bid). | ||
| execution payload header (builder's bid). A client MAY queue the sidecar for |
Contributor
There was a problem hiding this comment.
Any specific reason to use the word "queue" then just cache?
Member
Author
There was a problem hiding this comment.
Same language as in previous forks
Member
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a DataColumnSidecars arrives before the beacon block it's referencing. We don't yet how builders / users will use Gloas and publish things. To prevent instability, the spec should suggest to cache DataColumnSidecars the same way we cache attestations and aggregates for unknown beacon blocks.