Skip to content

Conversation

@shane-moore
Copy link
Contributor

Long form reasoning on this change in the discord chat

TLDR:
Move process_builder_pending_payments to run before process_effective_balance_updates in process_epoch. This makes compute_exit_epoch_and_update_churn use the current epoch effective balances, matching process_execution_payload behavior and avoiding inconsistent updates to state.exit_balance_to_consume and state.earliest_exit_epoch

@jtraglia jtraglia changed the title run process_builder_pending_payments before effective balance updates Run process_builder_pending_payments before effective balance updates Nov 11, 2025
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shane-moore, this change makes sense to me. We discussed this on the last ePBS breakout call and there was no real arguments against making this change. I believe potuz stated that he just added the call to the end of the function without much thought.

@jtraglia jtraglia merged commit 38a165d into ethereum:master Nov 14, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants