-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Set execution_payment field when constructing bid
#4804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
specs/gloas/builder.md
Outdated
| 11. Set `bid.execution_payment` to zero for in protocol payment via the beacon | ||
| chain balance. A non zero value indicates a trusted execution layer payment. | ||
| Bids with non zero `execution_payment` **MUST NOT** be broadcasted on the | ||
| P2P network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few little things:
- "in protocol" -> "in-protocol"
- "non zero" -> "non-zero"
- Let's remove "for in protocol payment via the beacon chain balance"
- "Bids with non zero
execution_paymentMUST NOT be broadcasted" -> "Bids with a non-zeroexecution_paymentMUST NOT be broadcast"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added!
| proposer if the bid is accepted. The builder **MUST** have enough excess | ||
| balance to fulfill this bid and all pending payments. | ||
| 11. Set `bid.blob_kzg_commitments_root` to be the `hash_tree_root` of the | ||
| 11. Set `bid.execution_payment` to zero. A non-zero value indicates a trusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple doubt: If it is set to 0, why do we have it? Is it used somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @satushh. This field is used by "trusted" builders for an out-of-protocol auction.
execution_payment field when constructing bid
Adds info related to
execution_paymentwhen constructingSignedExecutionPayloadBid