Remove deprecated INTERVALS_PER_SLOT constant
#4805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
changed the title
INTERVALS_PER_SLOT constant
Member
|
@0xmrree Please run |
Contributor
Author
|
@jtraglia bet, done |
Contributor
Author
jtraglia
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Given that
interval_per_slotin phase0 is not mentioned in any code in the specs or the config itself, can we just remove it from the fork choice spec to avoid confusion? I'm realizing that Lighthouse uses this variable in its internal slot timing and may need to refactor away from it to make it easier to implement the new GLOAS timing configs such as:ATTESTATION_DUE_BPS_GLOAS,AGGREGATE_DUE_BPS_GLOAS,SYNC_MESSAGE_DUE_BPS_GLOAS,CONTRIBUTION_DUE_BPS_GLOAS,PAYLOAD_ATTESTATION_DUE_BPS