Add initial fork choice tests for Gloas

[brech1]

Description

Adds initial fork choice tests for Gloas. Covers store initialization and the on_execution_payload handler that transitions blocks from EMPTY to FULL when a builder reveals a payload.

Checklist

• make lint
• make reftests fork=gloas runner=fork_choice
• make test fork=gloas k=test_genesis

Relations

• Related to eip7732: add fork choice tests (part1) #4489

[jtraglia]

Hey @brech1, nice thanks!

I want to point out that the make test command you mentioned in the PR description will not run these tests; the k flag collects all tests which contain the input string & "fork_choice" is not in "test_genesis" or "test_on_execution_payload". You could run make test fork=gloas k=test_genesis for example, or make reftests fork=gloas runner=fork_choice to run generate all fork-choice tests.

Also, I believe we'll need to update this test case to not run in Gloas+:

consensus-specs/tests/core/pyspec/eth_consensus_specs/test/phase0/fork_choice/test_get_head.py

Lines 47 to 49 in f73487b

	@with_altair_and_later
	@spec_state_test
	def test_genesis(spec, state):

On the other hand, if it's possible to add Gloas support to the function above, instead of defining a new test_genesis test function, I think that would be preferable.

[brech1]

I didn't realize k parameter was fn name matching, my bad. I ran both suggested commands and received correct outputs.

I was also not aware that it was ok/preferred to modify tests from older version specs on the go, adjusting them to newer params/cfg, instead of duplicating them/generating new ones on their respective fork directory.

Thanks a lot for the review!

[jtraglia]

Hey @brech1 we recently merged this PR which is why the CI check is failing.

• Replace SECONDS_PER_SLOT with SLOT_DURATION_MS in specs/tests #4926

You'll need to replace SECONDS_PER_SLOT with SLOT_DURATION_MS and divide by 1000 there.

[jtraglia]

LGTM, let's merge this. If for whatever reason there is an issue, clients can disable the test & we'll fix it in the next release.