Skip to content

Remove ad-hoc framework for generating reference tests#4994

Merged
jtraglia merged 5 commits intoethereum:masterfrom
jtraglia:remove-adhoc-generator
Mar 9, 2026
Merged

Remove ad-hoc framework for generating reference tests#4994
jtraglia merged 5 commits intoethereum:masterfrom
jtraglia:remove-adhoc-generator

Conversation

@jtraglia
Copy link
Member

@jtraglia jtraglia commented Mar 9, 2026

This PR is an extension of:

I have made several updates to the pytest reference test generator workflow & I cannot commit to Leo's branch. I have cherry-picked his commits from his PR. Additionally, this PR does the following:

  • Remove the "nightly mainnet tests" workflow since that's essentially a duplicate of the "nightly tests" action now. I have double checked and it still runs unit tests which do not produce any reference tests.
  • No longer run the tests twice in the release action. And I've decided to forgo running the framework tests as these are unlikely to be an issue; they are run on the master branch so it will be quickly noticed there.
  • Move the default location of reference tests from ../consensus-spec-tests to ./reftests which I believe is more intuitive, now that the consensus-spec-tests repo is deprecated.

Closes #4976.

@github-actions github-actions bot added the testing CI, actions, tests, testing infra label Mar 9, 2026
For general tests, not all forks result in an artifact. When it comes to
deleting them, it doesn't realize that and 404's.
@jtraglia jtraglia merged commit 0d4004f into ethereum:master Mar 9, 2026
5 checks passed
@jtraglia jtraglia deleted the remove-adhoc-generator branch March 9, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants