Skip to content

Integrate make coverage into make test#5015

Merged
jtraglia merged 2 commits intoethereum:masterfrom
brech1:restructure/make-coverage
Mar 24, 2026
Merged

Integrate make coverage into make test#5015
jtraglia merged 2 commits intoethereum:masterfrom
brech1:restructure/make-coverage

Conversation

@brech1
Copy link
Member

@brech1 brech1 commented Mar 18, 2026

Description

This PR removes the make coverage command and integrates it into make test through an optional coverage parameter.

The coverage report now supports all optionalities the make test command has. It's not compatible with framework only test runs.

The disable BLS option has been removed from the codebase. An issue has been created to track the removal of the @always_bls decorator.

A new json formatted coverage report is now generated, saved on the same directory as the HTML one.

@brech1 brech1 requested a review from jihoonsong March 18, 2026 01:38
@github-actions github-actions bot added the testing CI, actions, tests, testing infra label Mar 18, 2026
@brech1 brech1 changed the title restructure: integrate make coverage into make test Integrate make coverage into make test Mar 18, 2026
@brech1 brech1 marked this pull request as draft March 18, 2026 11:17
@brech1 brech1 marked this pull request as ready for review March 18, 2026 16:30
Copy link
Member

@jihoonsong jihoonsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and good quality. Great work!

@echo " make test preset=mainnet fork=deneb k=test_verify_kzg_proof"
@echo " make test bls=arkworks"
@echo " make test component=fw"
@echo " make test bls=arkworks"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brech1 brech1 force-pushed the restructure/make-coverage branch 4 times, most recently from ce62b67 to 6ec5392 Compare March 23, 2026 22:55
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks great 🙂

@jtraglia jtraglia enabled auto-merge (squash) March 23, 2026 23:37
@brech1 brech1 force-pushed the restructure/make-coverage branch from 0298104 to d951c60 Compare March 23, 2026 23:51
@jtraglia jtraglia merged commit 74912ed into ethereum:master Mar 24, 2026
16 checks passed
@brech1 brech1 deleted the restructure/make-coverage branch March 24, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants