Add check that block is known in on_payload_attestation_message#5022
Merged
jihoonsong merged 1 commit intoethereum:masterfrom Mar 23, 2026
Merged
Conversation
ericsson49
changed the title
on_payload_attestation_message on_payload_attestation_message
jihoonsong
approved these changes
Mar 22, 2026
jtraglia
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on_payload_attestation_message raises
KeyErrorifdata.beacon_block_rootrefers to unknown block.One consequence is that expect_assertion_error won't catch the error.
Historically, block roots are validated with an explicit
assert. The PR adds such a check.