Skip to content

Remove @always_bls decorator#5045

Closed
dzhalaevd wants to merge 2 commits intoethereum:masterfrom
dzhalaevd:5032-remove-always-bls
Closed

Remove @always_bls decorator#5045
dzhalaevd wants to merge 2 commits intoethereum:masterfrom
dzhalaevd:5032-remove-always-bls

Conversation

@dzhalaevd
Copy link
Copy Markdown

Description

Remove @always_bls decorator from the pyspec test suite and from docs

closes: #5032
related: #5015

Todo

  • Update documentation
  • Run make lint to check formatting
  • Run make test to check tests

@github-actions github-actions bot added the testing CI, actions, tests, testing infra label Mar 26, 2026
@brech1 brech1 changed the title chore: remove @always_bls decorator Remove @always_bls decorator Mar 27, 2026
@brech1
Copy link
Copy Markdown
Member

brech1 commented Mar 27, 2026

I'm afraid removing @always_bls also drops bls_setting: 1 from the generated test vectors, and this breaks clients test harnesses that rely on it to gate BLS verification.

This needs to be part of a broader bls_setting and never_bls restructure, not a standalone removal.

The best would be to postpone this change, any update on this decorator or bls_settings would need client teams coordination too. Thank you for working on it, didn't realize this when creating the issue 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove @always_bls decorator

2 participants