-
Notifications
You must be signed in to change notification settings - Fork 5.2k
perf: Homepage image optimization #15677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
convert jpg to 256-color png; reduce source file size
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
add trimmed version for 2xl screens where top/bottom never display; drop quality progressively on smaller devices
Noting- Much of this PR was simply testing out various image sizes and won't be merged, though a few aspects here we could still benefit from, such as loading portrait-cropped versions of the homepage section banners for desktop. Lower priority at the moment |
10c9e4e
to
9341a01
Compare
Noting that lighthouse scores aren't really responding much to these changes, and we've identified that the Nav component is much more of the problem here; not just the images. That being said, the image improvements will still help contribute to faster loads and better UX. Trimmed off the testing commits from this branch and opened those separately for further testing in #16004. This PR keeps the "art direction" changes and quality adjustments. Could consider backing off on the quality drop here, though after testing it sounds like most folks found the lower-than-normal quality settings to appear perfectly fine without too much pixel-peeping. Feedback still welcome. |
Description
srcset
used to tell next/image to target 512px width, since these do not extend full width.Todo
quality
setting, balancing trade-offs of load speed vs visual qualityPlayground: https://deploy-preview-15677--ethereumorg.netlify.app/en/hero
If scores show improvement, we can extract a re-usable component that uses this approach.
Related Issue
Ongoing performance initiatives: Homepage / Lighthouse LCP score