Skip to content

Conversation

wackerow
Copy link
Member

@wackerow wackerow commented Aug 10, 2025

Description

Revamps /what-is-ethereum page per latest designs

Existing components

  • ContentHero: feat: ContentHero design update #16032 updates the ContentHero to match the design presenting for this page revamp. This PR extends those changes—if this is not desired (or slowing anything down), ping me and I can remove from this PR so it doesn't block.
  • TableOfContents (ToC): used existing, applied classes to custom style in this case to match design -- Separate task: Incorporate this set of styling either as the default for the existing ToC, or add it as a simple variant that can be applied when using it.
  • FileContributors: Un-touched; not currently matching design. Suggesting this as separate task after confirm how we want to handle this component on all pages.
  • Quiz: 3 of 5 existing questions still match new content perfectly fine... two others need adjusting. Not currently in this PR, but should be a separate task to get this added back to the bottom of the page.

TODOs

  • Apply correct sizes to all images
  • FeedbackWidget added to bottom
  • Extract strings for intl
  • Add custom tracking events
  • Fill in remaining / confirm all links are populated and working

Preview link

https://deploy-preview-16042--ethereumorg.netlify.app/en/what-is-ethereum

Copy link

netlify bot commented Aug 10, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 5cbf335
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68ae70dbd5ddeb00083af39f
😎 Deploy Preview https://deploy-preview-16042--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 49 (🔴 down 1 from production)
Accessibility: 96 (🟢 up 6 from production)
Best Practices: 92 (no change from production)
SEO: 100 (🟢 up 8 from production)
PWA: 59 (🟢 up 6 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Aug 10, 2025
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Aug 12, 2025
@wackerow wackerow changed the title [wip] /what-is-ethereum revamp feat: /what-is-ethereum revamp Aug 12, 2025
@wackerow wackerow marked this pull request as ready for review August 12, 2025 20:11
@wackerow
Copy link
Member Author

Thanks @konopkja! cc: @pettinarip / @corwintines for code review

@konopkja If you could, take a peak at #16032 as well (ContentHero). This PR builds on top of that one, although it doesn't have to in case we aren't ready to proceed with that update (which affects many pages)

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gj @wackerow, left a few comments.

</div>

<div
className={cn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? can't we handle all these styles inside the ToC component to reuse them later? this is pretty hard to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, happy to do that... this initial approach was mainly to avoid altering the ToC until we had consensus on moving forward with this as a DS update. cc: @konopkja IIRC, you're suggesting we have three variations for the Toc?

  • Styling used on use-cases template (left side, single depth)
  • Styling used in the docs (right side, variable depth)
  • And this as a new third variant, which we'll start off by using on this page?

Can make these adjustments early next week

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: This styling was refactored to a TableOfContents variant named beginner in this PR. PR #16121 takes this further to deprecate LeftNavBar and incorporate that styling into TableOfContents as well as a new variant left, and renames the default variant used in the docs to docs.

@corwintines corwintines merged commit bb56ccd into dev Aug 27, 2025
6 checks passed
@corwintines corwintines deleted the what-is-ethereum branch August 27, 2025 03:53
This was referenced Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants