-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: /what-is-ethereum revamp #16042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
add namespace for /energy-consumption -- charts no longer being used on what-is-ethereum
Use font color indication instead of bold to avoid layout shifting
Thanks @konopkja! cc: @pettinarip / @corwintines for code review @konopkja If you could, take a peak at #16032 as well (ContentHero). This PR builds on top of that one, although it doesn't have to in case we aren't ready to proceed with that update (which affects many pages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gj @wackerow, left a few comments.
</div> | ||
|
||
<div | ||
className={cn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why? can't we handle all these styles inside the ToC component to reuse them later? this is pretty hard to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, happy to do that... this initial approach was mainly to avoid altering the ToC until we had consensus on moving forward with this as a DS update. cc: @konopkja IIRC, you're suggesting we have three variations for the Toc?
- Styling used on use-cases template (left side, single depth)
- Styling used in the docs (right side, variable depth)
- And this as a new third variant, which we'll start off by using on this page?
Can make these adjustments early next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: This styling was refactored to a TableOfContents variant named beginner
in this PR. PR #16121 takes this further to deprecate LeftNavBar
and incorporate that styling into TableOfContents as well as a new variant left
, and renames the default variant used in the docs to docs
.
Description
Revamps /what-is-ethereum page per latest designs
Existing components
variant
that can be applied when using it.TODOs
sizes
to all imagesPreview link
https://deploy-preview-16042--ethereumorg.netlify.app/en/what-is-ethereum