fix(consume): fix consume_direct.sh by quoting the testid passed to --filter (#1987)

Co-authored-by: danceratopz <[email protected]>

Author: felix314159

docs/CHANGELOG.md

@@ -89,6 +89,7 @@ Users can select any of the artifacts depending on their testing needs for their
 
 - ✨ Add `--extract-to` parameter to `consume cache` command for direct fixture extraction to specified directory, replacing the need for separate download scripts. ([#1861](https://github.com/ethereum/execution-spec-tests/pull/1861)).
 - 🐞 Fix `consume cache --cache-folder` parameter being ignored, now properly caches fixtures in the specified directory instead of always using the default system cache location.
+- 🐞 Fix the `consume_direct.sh` script generated by `consume` in the `--evm-dump` dir by quoting test IDs [#1987](https://github.com/ethereum/execution-spec-tests/pull/1987).
 - 🔀 `consume` now automatically avoids GitHub API calls when using direct release URLs (better for CI environments), while release specifiers like `stable@latest` continue to use the API for version resolution ([#1788](https://github.com/ethereum/execution-spec-tests/pull/1788)).
 - 🔀 Refactor consume simulator architecture to use explicit pytest plugin structure with forward-looking architecture ([#1801](https://github.com/ethereum/execution-spec-tests/pull/1801)).
 - 🔀 Add exponential retry logic to initial fcu within consume engine ([#1815](https://github.com/ethereum/execution-spec-tests/pull/1815)).

src/ethereum_clis/clis/geth.py

@@ -2,6 +2,7 @@
 
 import json
 import re
+import shlex
 import shutil
 import subprocess
 import textwrap
@@ -125,8 +126,19 @@ def _consume_debug_dump(
         fixture_path: Path,
         debug_output_path: Path,
     ):
-        debug_fixture_path = debug_output_path / "fixtures.json"
-        consume_direct_call = " ".join(command[:-1]) + f" {debug_fixture_path}"
+        # our assumption is that each command element is a string
+        assert all(isinstance(x, str) for x in command), (
+            f"Not all elements of 'command' list are strings: {command}"
+        )
+        assert len(command) > 0
+
+        # replace last value with debug fixture path
+        debug_fixture_path = str(debug_output_path / "fixtures.json")
+        command[-1] = debug_fixture_path
+
+        # ensure that flags with spaces are wrapped in double-quotes
+        consume_direct_call = " ".join(shlex.quote(arg) for arg in command)
+
         consume_direct_script = textwrap.dedent(
             f"""\
             #!/bin/bash

src/ethereum_clis/clis/nethermind.py

@@ -2,6 +2,7 @@
 
 import json
 import re
+import shlex
 import subprocess
 import textwrap
 from functools import cache
@@ -55,13 +56,21 @@ def _consume_debug_dump(
         result: subprocess.CompletedProcess,
         debug_output_path: Path,
     ):
-        consume_direct_call = " ".join(command)
+        # our assumption is that each command element is a string
+        assert all(isinstance(x, str) for x in command), (
+            f"Not all elements of 'command' list are strings: {command}"
+        )
+
+        # ensure that flags with spaces are wrapped in double-quotes
+        consume_direct_call = " ".join(shlex.quote(arg) for arg in command)
+
         consume_direct_script = textwrap.dedent(
             f"""\
             #!/bin/bash
             {consume_direct_call}
             """
         )
+
         dump_files_to_directory(
             str(debug_output_path),
             {