Skip to content

Conversation

@danceratopz
Copy link
Member

@danceratopz danceratopz commented Jan 22, 2025

πŸ—’οΈ Description

Adds some more edge cases for testing blob gas handling at fork transitions (for the case that blobs are already activated in both forks).

πŸ”— Related Issues

#1082

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.

@danceratopz danceratopz added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature labels Jan 22, 2025
@danceratopz danceratopz requested a review from marioevz January 22, 2025 19:41
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me, I'll apply the comments and merge.

@marioevz marioevz merged commit 3642881 into fork-transition-eip-7691 Jan 22, 2025
21 of 22 checks passed
@marioevz marioevz deleted the fork-transition-eip-7691-more-edge-cases branch January 22, 2025 20:03
marioevz added a commit that referenced this pull request Jan 22, 2025
* refactor(tests): EIP-4844, EIP-7691: Fill fork transition blob tests in newer forks

* fix(tests): Rebase fixes, add more checks to the test

* chengelog

* feat(tests): more blob gas tests for fork transitions (#1107)

* feat(tests): more edge cases for blob gas at transitions

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>

* fix(tests): Remove type-2 txs, destination account is empty

* tox: typing

---------

Co-authored-by: danceratopz <[email protected]>
fselmo pushed a commit to fselmo/execution-spec-tests that referenced this pull request Jan 24, 2025
* refactor(tests): EIP-4844, EIP-7691: Fill fork transition blob tests in newer forks

* fix(tests): Rebase fixes, add more checks to the test

* chengelog

* feat(tests): more blob gas tests for fork transitions (ethereum#1107)

* feat(tests): more edge cases for blob gas at transitions

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>

* fix(tests): Remove type-2 txs, destination account is empty

* tox: typing

---------

Co-authored-by: danceratopz <[email protected]>
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* refactor(tests): EIP-4844, EIP-7691: Fill fork transition blob tests in newer forks

* fix(tests): Rebase fixes, add more checks to the test

* chengelog

* feat(tests): more blob gas tests for fork transitions (ethereum#1107)

* feat(tests): more edge cases for blob gas at transitions

* Apply suggestions from code review

---------

Co-authored-by: Mario Vega <[email protected]>

* fix(tests): Remove type-2 txs, destination account is empty

* tox: typing

---------

Co-authored-by: danceratopz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants