Refactor to #1138 #1141
Merged
Refactor to #1138 #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
approved these changes
Jan 29, 2025
Member
danceratopz
left a comment
danceratopz
left a comment
There was a problem hiding this comment.
Thanks. Agree, nicer to have the invalid test cases grouped together.
I verified the fixtures locally.
LGTM. One very minor nit regarding id naming 😆
| correct_order_transactions, | ||
| correct_order + [bytes([fork.max_request_type() + 1])], | ||
| BlockException.INVALID_REQUESTS, | ||
| id="extra_invalid_type_request", |
Member
There was a problem hiding this comment.
I would just modify this test id to be more explicit and to better match the test cases removed from tests/prague/eip7685_general_purpose_el_requests/test_request_types.py
Suggested change
| id="extra_invalid_type_request", | |
| id="extra_invalid_type_request_with_no_data", |
In particular, the "no data" case triggers an Engine API error, whereas the with_data_* test cases don't. Makes it easier to filter/target the no data cases if nothing else.
Member
Author
There was a problem hiding this comment.
Makes total sense, thanks!
…_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]>
marioevz
added a commit
that referenced
this pull request
Jan 29, 2025
…n 1 byte (#1138) * fix(tests): raise `InvalidParams` for requests shorter than 1 byte * Refactor to #1138 (#1141) * refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: Mario Vega <[email protected]>
marioevz
added a commit
to marioevz/execution-spec-tests
that referenced
this pull request
Jan 30, 2025
…n 1 byte (ethereum#1138) * fix(tests): raise `InvalidParams` for requests shorter than 1 byte * Refactor to ethereum#1138 (ethereum#1141) * refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: Mario Vega <[email protected]>
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
…n 1 byte (ethereum#1138) * fix(tests): raise `InvalidParams` for requests shorter than 1 byte * Refactor to ethereum#1138 (ethereum#1141) * refactor(tests): EIP-7685: Add invalid cases * refactor(tests): EIP-7685: Remove redundant `test_request_types.py`, remove unused fixtures * small comment * Update tests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: danceratopz <[email protected]> --------- Co-authored-by: Mario Vega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of #1138.
tests/prague/eip7685_general_purpose_el_requests/test_request_types.pytotests/prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.pytests/prague/eip7685_general_purpose_el_requests/test_request_types.pyand the now unused fixtures it depended on.