Merged
Conversation
Member
This could even replace most of hive simulator tests if possible. The main issue right now is that most of the time we don't have full blobs in our tests but we only put the versioned hashes in the transaction. But perhaps we could put full blobs in the test transactions if we are running in execute mode (we could create a "mode" fixture that is populated with "fill" or "execute" depending on the pytest plugin). |
marioevz
reviewed
Apr 30, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
Thanks for this! Just a couple of comments.
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
* chore: add osaka engine updates. * chore(docs): add changelog. * Update src/ethereum_test_rpc/types.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update src/ethereum_test_rpc/types.py Co-authored-by: Mario Vega <marioevz@gmail.com> * chore: tox fixes. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* chore: add osaka engine updates. * chore(docs): add changelog. * Update src/ethereum_test_rpc/types.py Co-authored-by: Mario Vega <marioevz@gmail.com> * Update src/ethereum_test_rpc/types.py Co-authored-by: Mario Vega <marioevz@gmail.com> * chore: tox fixes. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Following: ethereum/execution-apis#630
I don't think we needed to change much on our end but please double check. I added the
get_blobsengine rpc method here on the assumption that we can maybe create a test suite that sends blob txs to ELs, then we callget_blobsto validate the response. This feels suited towards an extension inexecute.🔗 Related Issues
N/A.
✅ Checklist