Skip to content

feat(tests): port intrinsic transaction gas tests from Ori#1535

Merged
marioevz merged 3 commits intomainfrom
intrinsicgen
May 12, 2025
Merged

feat(tests): port intrinsic transaction gas tests from Ori#1535
marioevz merged 3 commits intomainfrom
intrinsicgen

Conversation

@winsvega
Copy link

@winsvega winsvega commented May 5, 2025 •
edited
Loading

🗒️ Description

This combination tests are failing in Prague, I port it now as it can not be adjusted in .json tests. (the filler was removed in ethereum/tests)
So now we can easily switch formula calculation in python.

TODO

  • support this test on Prague

🔗 Related Issues

#1199

ethereum/tests#1488

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@winsvega winsvega force-pushed the intrinsicgen branch 2 times, most recently from 1049a46 to 2713f01 Compare May 5, 2025 11:13
@winsvega winsvega added scope:tests Scope: Changes EL client test cases in `./tests` fork:prague Prague hardfork labels May 5, 2025
@winsvega winsvega requested review from danceratopz and marioevz May 5, 2025 11:16
@winsvega winsvega self-assigned this May 5, 2025
marioevz
marioevz reviewed May 5, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of comments, thanks!

@winsvega winsvega changed the base branch from main to coverage May 6, 2025 08:23
@winsvega winsvega mentioned this pull request May 6, 2025
Merged
8 tasks
@winsvega winsvega changed the base branch from coverage to main May 6, 2025 08:28
@winsvega
Copy link
Author

winsvega commented May 6, 2025

with this PR it can measure the coverage diff of blockchain converted tests as well
#1554

@winsvega
Copy link
Author

winsvega commented May 6, 2025 •
edited
Loading

coverage state revert is lost, but that's not the point of the test.
also evmone does not support blockchain tests with invalid blocks (

@winsvega winsvega requested a review from marioevz May 6, 2025 09:21
@winsvega winsvega mentioned this pull request May 6, 2025
Closed
5 tasks
marioevz
marioevz approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased, removed some unnecessary lines, and changed the parametrization to test both type-1 and type-2 tx instead on only type-2 after London.

@winsvega
Copy link
Author

winsvega commented May 7, 2025

Some more bc tests can be romved now.
I wait for evmone to support invalid bc tests to run the coverage.

@marioevz
Copy link
Member

marioevz commented May 7, 2025

Interestingly, with #1554, the base blockchain tests from ethereum/tests are failing for evmone: https://github.com/ethereum/execution-spec-tests/actions/runs/14888483032/job/41814347440?pr=1535

@spencer-tb spencer-tb mentioned this pull request May 9, 2025
Closed
14 tasks
@marioevz
Copy link
Member

marioevz commented May 9, 2025

@winsvega should it be ok to merge this with the failing coverage?

@winsvega
Copy link
Author

winsvega commented May 9, 2025

Yes, I can trigger coverage rerun once evmone implementation is ready

@marioevz marioevz merged commit 33df23d into main May 12, 2025
21 of 22 checks passed
@marioevz marioevz deleted the intrinsicgen branch May 12, 2025 19:24
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@marioevz @felix314159
feat(tests): port intrinsic transaction gas tests from Ori (ethereum#…
9d5e79c 
…1535)

* port intrinsic transaction gas tests from Ori

* fix(tests): Make test run with both tx types

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@marioevz
feat(tests): port intrinsic transaction gas tests from Ori (ethereum#…
a211b64 
…1535)

* port intrinsic transaction gas tests from Ori

* fix(tests): Make test run with both tx types

---------

Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz approved these changes

@danceratopz danceratopz Awaiting requested review from danceratopz

Assignees

@winsvega winsvega

Labels

fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@winsvega @marioevz