fix(ci): eliminate duplicate CI runs in tox workflow #1811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change eliminates redundant CI executions by: - Limiting 'push' triggers to only the 'main' branch for post-merge verification - Using 'pull_request' for PR validation to run exactly once per commit - Adding concurrency control to cancel in-progress runs when new commits are pushed Before: Each PR commit triggered CI twice (push + pull_request events) After: Each PR commit triggers CI exactly once (pull_request event only) The workflow still runs on push to main and supports all merge scenarios while preventing resource waste from duplicate executions.
danceratopz
commented
Jun 27, 2025
danceratopz
added
type:bug
spencer-tb
approved these changes
Jun 27, 2025
|
Should we remove the 3.10 python runs in this PR? Maybe better to have a seperate PR that removes 3.10 from everywhere (not just CI). |
felix314159
approved these changes
Jun 27, 2025
Always haz been cf #1808 |
Y'all are fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR tries to eliminate the most obvious inefficiency in our current CI: Duplicated tox_verify runs, e.g.
It won't make individual jobs quicker, but it will stop jobs getting queued up and delaying CI for a PR.
It eliminates redundant CI executions by:
Before the change:
After the change:
Key differences:
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.All: Considered adding an entry to CHANGELOG.md.skipped