tests(benchmark): port additional Nethermind cases

[LouisTsai-Csie]

🗒️ Description

Most gas-benchmark test has been ported; more details can be found in the issue tracker. These are the new cases that need to be ported based on this branch.

• Log0Empty
• Log01byte
• Log032bytes
• Log01KiB
• Log016KiB
• Log4WithoutData
• Mod1
• ModexpMod8Exp648
• ModexpMod8Exp896
• ModexpMod32Exp32
• ModexpMod32Exp36
• ModexpMod32Exp40
• ModexpMod32Exp64
• ModexpMod32Exp65
• ModexpMod32Exp128
• ModexpMod256Exp2
• ModexpMod264Exp2
• ModexpMod1024Exp2
• ModexpVulnerabilityZkevmWorst
• EcPairing1Pair
• EcPairing2Pairs
• EcPairing3Pairs
• EcPairing4Pairs
• EcPairing5Pairs
• EcPairing10Pairs
• EcPairing2SetsUnique
• Secp256r1InvalidSignature

🔗 Related Issues or PRs

Issue

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered adding an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

[LouisTsai-Csie]

More information on the LOG opcodes: we already support LOG0 to LOG4 operations, covering both zero and non-zero topics, as well as data sizes of 0 and 1 MiB. The implementation can be found here.

I think we won’t port the 1-byte, 32-byte, 1 KiB, or 16 KiB scenarios, as we try to reduce the number of tests and already include the 1 MiB cases. Some previous discussion on this topic can be found here.

[marcindsobczak]

Seems reasonable. You can ignore our Log test cases, I started working on them in Berlin, but never finished properly

[LouisTsai-Csie]

@marcindsobczak can you provide the generator for Mod1, EcPairing10Pairs and EcPairing2SetsUnique, as I can not find them in your PR.

[marcindsobczak]

Generators for it doesn't exist. Seems like I added TestCase and never delivered. Sorry for a mess

[LouisTsai-Csie]

@marcindsobczak Thanks, I will request review from our team and include them in next benchmark release.

How can we collaborate to verify all the test case in gas-benchmark are fully ported?

[spencer-tb]

LGTM! Is Secp256r1InvalidSignature missing?

[fselmo]

Lgtm as well! I had the same question on Secp256r1InvalidSignature.

[LouisTsai-Csie]

Thank you for your review!

Currently, we don’t have precompile tests for invalid input cases. It would be worth adding new tests for all precompiles. I’ve created an issue to track this , i might want to add it in a separate PR, as the methodology would be slightly different.

cc @spencer-tb @fselmo