Skip to content

chore(consume): remove non-functional hive command #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −13
Open

chore(consume): remove non-functional hive command #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ Users can select any of the artifacts depending on their testing needs for their

### 📋 Misc

- 🔀 Remove non-functional `consume hive` command. `consume rlp` and `consume engine` to be used instead instead. ([#2008](https://github.com/ethereum/execution-spec-tests/pull/2008)).
- ✨ Add pypy3.11 support ([#1854](https://github.com/ethereum/execution-spec-tests/pull/1854)).
- 🔀 Use only relative imports in `tests/` directory ([#1848](https://github.com/ethereum/execution-spec-tests/pull/1848)).
- 🔀 Convert absolute imports to relative imports in `src/` directory for better code maintainability ([#1907](https://github.com/ethereum/execution-spec-tests/pull/1907)).
Expand Down
13 changes: 1 addition & 12 deletions src/cli/pytest_commands/consume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,7 @@ def create_consume_command(
def get_command_logic_test_paths(command_name: str, is_hive: bool) -> List[Path]:
"""Determine the command paths based on the command name and hive flag."""
base_path = Path("pytest_plugins/consume")
if command_name == "hive":
commands = ["rlp", "engine"]
command_logic_test_paths = [
base_path / "simulators" / "simulator_logic" / f"test_via_{cmd}.py" for cmd in commands
]
elif command_name in ["engine", "rlp"]:
if command_name in ["engine", "rlp"]:
command_logic_test_paths = [
base_path / "simulators" / "simulator_logic" / f"test_via_{command_name}.py"
]
Expand Down Expand Up @@ -117,12 +112,6 @@ def sync() -> None:
pass


@consume_command(is_hive=True)
def hive() -> None:
"""Client consumes via all available hive methods (rlp, engine)."""
pass


@consume.command(
context_settings={"ignore_unknown_options": True},
)
Expand Down
1 change: 0 additions & 1 deletion src/pytest_plugins/help/tests/test_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def test_local_arguments_present_in_fill_help(pytester, help_flag):
("direct", "--consume-help"),
("rlp", "--consume-help"),
("engine", "--consume-help"),
("hive", "--consume-help"),
],
)
def test_local_arguments_present_in_base_consume_help(pytester, help_flag, command):
Expand Down
Loading