chores(src): nuke fixtures dir when html is disabled and no tests were filled

[felix314159]

🗒️ Description

Fixes #1613 but only under the condition that you add --no-html to your command.
LMK what you think, another alternative would have been to somehow attach to the pytest-html plugin and at the end of that detect whether any tests have been written or not and let it perform the nuke, but that seemed overly complicated.

The general problem is that the html plugin just assumes that it can write to the fixtures dir, so nuking it no matter what would create problems if this PR would not also check whether --no-html had been passed or not.

LMK what you think.

How to reproduce

uv run fill --fork Frontier tests/istanbul/eip1344_chainid/ -s -v --clean --no-html --output=./testoutput

• Before: creates useless testoutput folder with html report etc
• After: No new folder is created

uv run fill --fork Frontier tests/istanbul/eip1344_chainid/ -s -v --clean

• Before & after: creates a bunch of useless files

uv run fill --fork istanbul tests/istanbul/eip1344_chainid/ -s -v --clean

• Before & after: Fills tests as expected

LMK what you think

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered adding an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

[marioevz]

Hey, just one comment to make this a bit safer, but in general I think it's a good idea 👍

[marioevz]

I think we should use the FixtureOutput object from src/pytest_plugins/filler/fixture_output.py to determine the appropriate folder to drop here because, while the default is indeed fixtures, it really depends on the --output flag of the command.

[felix314159]

Yes you are right, thanks. I have added it