Skip to content

chore(cli): update blob per tx limit for reth exception mapper #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025

Conversation

fgimenez
Copy link
Contributor

@fgimenez fgimenez commented Aug 8, 2025

Should fix hive errors like https://github.com/paradigmxyz/reth/actions/runs/16830025306/job/47676885890

2025-08-08 16:50:01.696+00:00 [FAIL] pytest_plugins.consume.simulators.simulator_logic.test_via_engine: Undefined exception message: expected exception: "[<TransactionException.TYPE_3_TX_MAX_BLOB_GAS_ALLOWANCE_EXCEEDED: 60>, <TransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED: 58>]", returned exception: "EVM reported invalid transaction (0x4c87659c227bd100a078bc9584ff67a3af1b296a83087c769b60c7ce556ab085): too many blobs, have 7, max 6" (mapper: "RethExceptionMapper")

@spencer-tb spencer-tb self-requested a review August 8, 2025 18:32
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating this. Appreciate it!

@spencer-tb spencer-tb added type:chore Type: Chore fork:osaka Osaka hardfork scope:cli Scope: Changes to `ethereum_clis` labels Aug 11, 2025
@spencer-tb spencer-tb changed the title Add blob per tx limit for reth chore(cli): update blob per tx limit for reth exception mapper Aug 11, 2025
@spencer-tb
Copy link
Contributor

Our linter is failing, could you update it to all be on one line:

        TransactionException.TYPE_3_TX_BLOB_COUNT_EXCEEDED: r"too many blobs, have \d+, max \d+",

To confirm it passes you can run:

uvx --with=tox-uv tox -e lint

@fgimenez
Copy link
Contributor Author

Our linter is failing, could you update it to all be on one line:

ok done here 0f4b950 with this i get:

$ uvx --with=tox-uv tox -e lint
lint: uv-sync> uv sync --locked --python-preference system --extra lint -p /home/home-link/.cache/uv/archive-v0/i8fKthlQu5NdiVMUQkOvt/bin/python
lint: commands[0]> ruff check --no-fix --show-fixes src tests .github/scripts
All checks passed!
lint: commands[1]> ruff format --check src tests .github/scripts
691 files already formatted
  lint: OK (0.07=setup[0.03]+cmd[0.02,0.03] seconds)
  congratulations :) (0.11 seconds)

thx!

@spencer-tb spencer-tb merged commit 8383eff into ethereum:main Aug 12, 2025
15 checks passed
@fgimenez fgimenez deleted the fgimenez/bpt-hive branch August 12, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:cli Scope: Changes to `ethereum_clis` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants