Skip to content

fix(tests): Remove duplicates from secp256r1_test.json #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Aug 8, 2025

πŸ—’οΈ Description

Remove a bunch of duplicates from tests/osaka/eip7951_p256verify_precompiles/vectors/secp256r1_test.json, potentially the source of the test cases had different encoding, but they resulted in the same pre-compile input so we are removing them to not fill unnecessary tests.

To verify, do:

jq -r '.[].Input' tests/osaka/eip7951_p256verify_precompiles/vectors/secp256r1_test.json | sort -u

before and after this PR and confirm that there were no unique inputs removed.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@marioevz marioevz requested a review from LouisTsai-Csie August 8, 2025 22:31
@marioevz marioevz added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore labels Aug 8, 2025
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked out the main branch to count the unique test cases, and the result is 294, which matches the output of
jq -r '.[].Input' tests/osaka/eip7951_p256verify_precompiles/vectors/secp256r1_test.json | sort -u | wc -l
which counts the unique test cases in the vector list of this PR.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! πŸš€

@marioevz marioevz merged commit 41c9057 into main Aug 11, 2025
15 checks passed
@marioevz marioevz deleted the remove-p256-vector-file-duplicates branch August 11, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants