Skip to content

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented Aug 21, 2025

🗒️ Description

PR #2067 moves Block Access List (BAL) tests into Amsterdam but Amsterdam fork should be introduced by itself. In case we begin adding other EIPs while still iterating on BAL, we don't want to attach the fork to that PR.

I will remove the fork addition from there and build on top of this once this is ready and merged.

🔗 Related Issues or PRs

#2067

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@fselmo fselmo force-pushed the feat/amsterdam-fork branch from d729d1d to d664d4f Compare August 21, 2025 21:46
@fselmo fselmo added scope:forks Scope: Changes ethereum_test_forks package type:feat type: Feature fork: amsterdam Amsterdam hard fork labels Aug 21, 2025
@fselmo fselmo force-pushed the feat/amsterdam-fork branch from d664d4f to 2bd2fc1 Compare August 21, 2025 21:50
@fselmo fselmo marked this pull request as ready for review August 21, 2025 21:51
@fselmo
Copy link
Collaborator Author

fselmo commented Aug 21, 2025

For now I'm pointing this to the most up-to-date Amsterdam branch on the EELS side in the resolutions file.

I'm not quite sure why running uv run fill --fork=Amsterdam --clean runs into some issues with excess_blob_gas in header. Looking into it. But I wanted to separate the fork addition from PR #2067.

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small comment. Feel free to merge

@fselmo fselmo merged commit 90592a8 into ethereum:main Aug 22, 2025
15 of 16 checks passed
@fselmo fselmo deleted the feat/amsterdam-fork branch August 22, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork: amsterdam Amsterdam hard fork scope:forks Scope: Changes ethereum_test_forks package type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants