refactor(tests): add checklist marker for eip7883#2098
Merged
spencer-tb merged 11 commits intoethereum:mainfrom Sep 16, 2025
Merged
refactor(tests): add checklist marker for eip7883#2098spencer-tb merged 11 commits intoethereum:mainfrom
spencer-tb merged 11 commits intoethereum:mainfrom
Conversation
b269c24 to
a6ab7b5
Compare
Collaborator
Author
|
I am not very sure about intention for For the |
a6ab7b5 to
a3e62c8
Compare
This was referenced Sep 9, 2025
a3e62c8 to
0a1c8ba
Compare
LouisTsai-Csie
commented
Sep 10, 2025
0a1c8ba to
d4fa096
Compare
8 tasks
spencer-tb
approved these changes
Sep 15, 2025
Collaborator
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM! Really glad we are checking the precompile result too, and nice gas used parameterization!
tests/osaka/eip7883_modexp_gas_increase/test_modexp_thresholds.py
Outdated
Show resolved
Hide resolved
Collaborator
|
Could we also overwrite the test id for the transition test: @pytest.mark.parametrize(
"modexp_input,modexp_expected,gas_old,gas_new",
[
pytest.param(Spec.modexp_input, Spec.modexp_expected, 200, 1200),
],
ids=[""],
)Otherwise we get a huge test id :) Ohh, and ethereumjs mentioned it was a pain to parse @pytest.mark.parametrize(
"modexp_expected,call_succeeds",
[
pytest.param(bytes(), False),
],
ids=[""],
) |
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
* refactor: add checklist marker for eip7883 * doc: update eip checklist template * refactor: update modexp test and add checklist marker * chore: update checklist rules * refactor: enhance modexp checklist descriptions for clarity * refactor: update coverage table and check gas usage * fix rebase issue * chore: remove outdated entry from modexp checklist * refactor: expand modexp checklist with external coverage entries * refactor: adjust gas usage assertion for only Osaka fork * refactor: overwrite id and add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
EIP-7883 updates the gas calculation formula. This PR marks the appropriate checklist item for the eip.
This category aligns with the
Gas Cost Changessection, but since test coverage in the previous fork was incomplete, I’ve included it underNew Precompilesfor review.New Precompiles - Link
test_set_code_txs.py.Gas Cost Changes - Link
Missing Test:
🔗 Related Issues or PRs
Issue ethereum/execution-specs#1564
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.