✨ feat(tests): EIP-7928 Single-Opcode Success and OOG test cases#2118
✨ feat(tests): EIP-7928 Single-Opcode Success and OOG test cases#2118
Conversation
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_oog.py
Outdated
Show resolved
Hide resolved
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_oog.py
Outdated
Show resolved
Hide resolved
780a23e to
c89d947
Compare
c89d947 to
4f79419
Compare
|
@raxhvl, as you know, we're pushing toward The Weld™ at the moment (eels + eest merging) and so we are trying to get PRs close to mergeable. I'm happy to go a different direction here but this needed a rebase, lint fixing, and all the tests needed the expectations updated so I made some decisions and pushed them that we can then work on top of. Let's discuss the approach here if this is not what we want but my changes here, other than rebasing and lint fix, were:
I think this makes the cases more obvious to a reader (subtracting exactly |
4f79419 to
4453022
Compare
|
Thanks @fselmo, I agree with all your decisions. I think between this and the positive we cover a lot of ground. @marioevz does it cover everything you had in mind? There are some more OOG test cases in this PR: #2116, lets add them later and keep this PR minimal. I made a small change - added ids to test parameters to make results more readable. 6d0de55 |
4453022 to
e8b5ca4
Compare
tests/amsterdam/eip7928_block_level_access_lists/test_block_access_lists_opcodes.py
Outdated
Show resolved
Hide resolved
…ereum#2118) * ✨ feat(EIP-7928): OOG: Intrinsic gas * 🚧 wip(EIP-7928): OOG tests * fix: BAL expectations for OOG 7928 tests - fix linter * remove equivalent test cases as covered by opcode cases * 🥢 nit: named parameters * fix: Tighten up validation for empty lists on BALs * chore: CHANGELOG entry * chore: fix docstring after refactor --------- Co-authored-by: raxhvl <raxhvl@users.noreply.github.com> Co-authored-by: fselmo <fselmo2@gmail.com>
🗒️ Description
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.