Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Sep 12, 2025

🗒️ Description

In the previous PR, we update the benchmark CI to start from Prague. But when running fill locally, it still starts from Homestead/Frontier.

Example command:

uv run fill -v tests/benchmark/test_worst_compute.py::test_worst_swap -m benchmark --clean --gas-benchmark-values 1 --from=Prague -k "SWAP16"

This PR adds a filter that:

  • Runs the test from the specified fork if a valid_from marker is provided.
  • Otherwise, runs the test starting from Prague.

As a result, i remove all the redundant marker (from Cancun).

🔗 Related Issues or PRs

None

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. LGTM. Thanks!

@spencer-tb spencer-tb merged commit ff6aca4 into ethereum:main Sep 12, 2025
16 checks passed
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
* fix: update starting fork for benchmark test

* doc: update benchmark fork description

* refactor: update benchmark test generation to use a default benchmark fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants