Skip to content

fix(tests): fix storage slot of actual value for eip7516_blobgasfee tests in execute remote #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2025
+2 −1
Merged

fix(tests): fix storage slot of actual value for eip7516_blobgasfee tests in execute remote #2266

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e46f83
Fix storage slot of expected value
acuarica Oct 4, 2025
ea972f4
Fix test for `fill` mode
acuarica Oct 6, 2025
1a2255e
Merge branch 'ethereum:main' into fix-eip7516_blobgasfee-expected-sto…
acuarica Oct 6, 2025
8b0ef6f
Apply reviewer's suggestion to rename parameter
acuarica Oct 6, 2025
c3e4b09
Apply suggestion to use `SELFBALANCE` as result slot
acuarica Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/cancun/eip7516_blobgasfee/test_blobgasfee_opcode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,20 @@ def callee_address(pre: Alloc, callee_code: Bytecode) -> Address:
return pre.deploy_contract(callee_code)


@pytest.fixture
def store_slot() -> Bytecode:
"""Storage slot where to save the expected value, by default 1."""
return Op.PUSH1(1)


@pytest.fixture
def caller_code(
call_gas: int,
callee_address: Address,
store_slot: Bytecode,
) -> Bytecode:
"""Bytecode used to call the bytecode containing the BLOBBASEFEE opcode."""
return Op.SSTORE(Op.NUMBER, Op.CALL(gas=call_gas, address=callee_address))
return Op.SSTORE(store_slot, Op.CALL(gas=call_gas, address=callee_address))


@pytest.fixture
Expand Down Expand Up @@ -191,6 +198,7 @@ def test_blobbasefee_before_fork(
timestamps = [7_500, 14_999, 15_000]


@pytest.mark.parametrize("store_slot", [Op.NUMBER])
@pytest.mark.parametrize(
"caller_pre_storage",
[{block_number: 0xFF for block_number, _ in enumerate(timestamps, start=1)}],
Expand Down
Loading