Skip to content

More readable create_gas_cost calculation #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
Merged

More readable create_gas_cost calculation #1254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/ethereum/arrow_glacier/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/berlin/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,11 +354,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/byzantium/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,11 +274,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/cancun/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/constantinople/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/gray_glacier/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/istanbul/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/london/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,11 +353,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/muir_glacier/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,11 +344,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/osaka/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,9 @@ def call(evm: Evm) -> None:
) = access_delegation(evm, code_address)
access_gas_cost += delegated_access_gas_cost

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/paris/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,11 +352,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/prague/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,11 +385,9 @@ def call(evm: Evm) -> None:
) = access_delegation(evm, code_address)
access_gas_cost += delegated_access_gas_cost

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/shanghai/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,11 +372,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
8 changes: 3 additions & 5 deletions src/ethereum/spurious_dragon/vm/instructions/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,9 @@ def call(evm: Evm) -> None:

code_address = to

create_gas_cost = (
Uint(0)
if is_account_alive(evm.message.block_env.state, to) or value == 0
else GAS_NEW_ACCOUNT
)
create_gas_cost = GAS_NEW_ACCOUNT
if value == 0 or is_account_alive(evm.message.block_env.state, to):
create_gas_cost = Uint(0)
transfer_gas_cost = Uint(0) if value == 0 else GAS_CALL_VALUE
message_call_gas = calculate_message_call_gas(
value,
Expand Down
Loading