chore: WELD tooling (switch over to uv+ruff) #1326
Conversation
Carsons-Eels
added
A-tool
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
de664a3 to
c7b7921
Compare
Carsons-Eels
changed the title
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
c7b7921 to
4575502
Compare
SamWilsn
force-pushed
the
forks/osaka
branch
3 times, most recently
from
301eb89 to
5a49b2f
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
4 times, most recently
from
c1e9043 to
d07a600
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1326 +/- ##
===============================================
- Coverage 94.26% 94.25% -0.01%
===============================================
Files 583 583
Lines 34666 34665 -1
Branches 3070 3070
===============================================
- Hits 32677 32675 -2
- Misses 1454 1455 +1
Partials 535 535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
b21964e to
2b26dcc
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
2b26dcc to
88598e6
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
3 times, most recently
from
3b90303 to
d43f696
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
2 times, most recently
from
8405348 to
69c991e
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
69c991e to
49a11b4
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
2 times, most recently
from
b68880e to
4b16b89
Compare
src/ethereum/trace.py
Outdated
| @@ -212,6 +216,7 @@ def __call__( | |||
| [evm]: ref:ethereum.frontier.vm.Evm | |||
| [`TraceEvent`]: ref:ethereum.trace.TraceEvent | |||
| """ | |||
| del evm, event | |||
There was a problem hiding this comment.
Does raise NotImplementedError also mute the warning? I think raising that error would be more semantically correct.
There was a problem hiding this comment.
Just checked, yep it does. I'll switch it over
tox.ini
Outdated
| -m "not slow and not zkevm and not benchmark" \ | ||
| -n auto --maxprocesses 6 \ | ||
| -n auto --maxprocesses 10 \ |
There was a problem hiding this comment.
Yeah, I thought we had updated this to 10, but then it switched back lower to 6. Was that because of impacts to the performance of the CI machine? If so, then I'll revert it
There was a problem hiding this comment.
Yeah exactly. We were OOMing
There was a problem hiding this comment.
These are flipped I think? json_infra used to have 10 while py3 had 6.
Carsons-Eels
force-pushed
the
WELD_tooling
branch
8 times, most recently
from
2c30dd7 to
981d13f
Compare
src/ethereum/trace.py
Outdated
| ) -> None: | ||
| """ | ||
| An [`EvmTracer`] that discards all events. | ||
| [`EvmTracer`]: ref:ethereum.trace.EvmTracer | ||
| """ | ||
|
|
||
| raise NotImplementedError |
There was a problem hiding this comment.
This one needs to be del because it actually gets called. If I commented on this one, my bad 😅
tox.ini
Outdated
| -m "not slow and not zkevm and not benchmark" \ | ||
| -n auto --maxprocesses 6 \ | ||
| -n auto --maxprocesses 10 \ |
There was a problem hiding this comment.
These are flipped I think? json_infra used to have 10 while py3 had 6.
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
981d13f to
2137ea1
Compare
Carsons-Eels
force-pushed
the
WELD_tooling
branch
from
2137ea1 to
e64137f
Compare
What was wrong?
In order to WELD we're going to need to align on tooling, and this is an attempt to see how painful it will be to migrate to uv and ruff, leaving behind flake8, black, and isort (the latter two are covered by rules in ruff).
Related to Issue #
How was it fixed?
Updated the project config
Cute Animal Picture