-
Notifications
You must be signed in to change notification settings - Fork 330
feat(amsterdam): Implement EIP-7819 SETDELEGATE #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Amxx
wants to merge
37
commits into
ethereum:forks/osaka
Choose a base branch
from
Amxx:eips/amsterdam/eip-7819
base: forks/osaka
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to latest EIP-7918 * EIP-7918 t8n tool update --------- Co-authored-by: Sam Wilson <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
* feat(vm): add eip-7939 count leading zeros opcode. * Update src/ethereum/osaka/vm/instructions/bitwise.py Co-authored-by: Guruprasad Kamath <[email protected]> * code formatting --------- Co-authored-by: Guruprasad Kamath <[email protected]> Co-authored-by: Guruprasad Kamath <[email protected]>
…state management and interpreter. Updated comments for clarity on the implications of SELFDESTRUCT.
…MAX_CODE_SIZE across multiple modules
update exceptions for other forks fix tests use fork module rename to NonceOverFlowError revert load test catching specific exc style: indent comment line
- ignore all pytest functions - remove unused variables, functions, methods, and classes - create vulture whitelist and mark some code that either implicitly gets called or only gets called during test runs for vulture to ignore
Signed-off-by: bytetigers <[email protected]>
301eb89
to
5a49b2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-7819 is missing from this repo :)
How was it fixed?
In the absence of forks/amsterdam, I just
cp -r src/ethereum/osaka src/ethereum/amsterdam
and iterated on top of that. Relevant changes are in commit c71163e and followingHappy to rebase on top of a
forks/amsterdam
branch when that becomes available.I'm not familiar with this repo. How should testing be done ?
Cute Animal Picture