Skip to content

Fix: Redundant destroy_storage call within process_create_message #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix: Redundant destroy_storage call within process_create_message #1348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions src/ethereum/prague/vm/interpreter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,18 +177,6 @@ def process_create_message(message: Message) -> Evm:
# take snapshot of state before processing the message
begin_transaction(state, transient_storage)

# If the address where the account is being created has storage, it is
# destroyed. This can only happen in the following highly unlikely
# circumstances:
# * The address created by a `CREATE` call collides with a subsequent
# `CREATE` or `CREATE2` call.
# * The first `CREATE` happened before Spurious Dragon and left empty
# code.
destroy_storage(state, message.current_target)

# In the previously mentioned edge case the preexisting storage is ignored
# for gas refund purposes. In order to do this we must track created
# accounts.
mark_account_created(state, message.current_target)

increment_nonce(state, message.current_target)
Expand Down