Implement EIP-7805 #1349
Open
Implement EIP-7805 #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonsong
force-pushed
the
eips/osaka/eip-7805
branch
from
464b859 to
8da7485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
This PR implements EIP-7805.
How was it fixed?
When testing IL validation, we would only need to modify blockchain tests. Hence, t8n's
run_blockchain_test()has been updated to validate IL constraints whilerun_state_test()remains unchanged.Meanwhile,
add_block_to_chain(), which runsstate_transition, effectively performs no-ops for IL validation. It seems it doesn’t differentiate behavior based on the fork, so the modifiedstate_transitionreceives an empty Tuple by default for simplicity.Cute Animal Picture