Skip to content

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented Jul 29, 2025

Draft because there are some open questions about how to expose the feature.

Ready to merge, probably after #1356

What was wrong?

closes #1351

How was it fixed?

Added a counting trace implementation.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (a7b8712) to head (32aaf7c).
⚠️ Report is 2132 commits behind head on forks/osaka.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##           forks/osaka    #1353   +/-   ##
============================================
  Coverage        94.26%   94.26%           
============================================
  Files              583      583           
  Lines            34666    34666           
  Branches          3070     3070           
============================================
  Hits             32677    32677           
  Misses            1454     1454           
  Partials           535      535           
Flag Coverage Δ
unittests 94.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SamWilsn SamWilsn force-pushed the count-opcodes branch 2 times, most recently from 2bbbe6e to 8796a05 Compare July 30, 2025 18:32
@SamWilsn SamWilsn marked this pull request as ready for review July 30, 2025 18:32
@SamWilsn SamWilsn force-pushed the count-opcodes branch 3 times, most recently from b903471 to 0029a4a Compare August 6, 2025 17:50
@SamWilsn SamWilsn requested a review from marioevz August 12, 2025 17:17
Copy link
Contributor

@Carsons-Eels Carsons-Eels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things

@SamWilsn SamWilsn merged commit 1626a8c into ethereum:forks/osaka Aug 22, 2025
8 checks passed
@SamWilsn SamWilsn deleted the count-opcodes branch August 22, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a trace option that counts executed opcodes
3 participants