Fix: Redundant account destruction after state modification #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EperezOk
changed the title
SamWilsn
force-pushed
the
fix/redundant-account-existence-checks
branch
from
3adbb4e to
a9ce06c
Compare
|
@SamWilsn please let me know if anything else is needed from my side or if I should mark the PR as "ready for review" |
|
Hey! Thanks for the fix. If you're feeling lazy, you can leave this and we'll do the rest of the work ourselves eventually. Otherwise, it'll need to be ported to the other post-merge forks before we can merge. If you're feeling super enthusiastic, might be worth investigating whether we can remove |
…ub.com/EperezOk/execution-specs into fix/redundant-account-existence-checks
|
Hi @SamWilsn! I ported the change to the other post-merge forks. I also confirmed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1354
How was it fixed?
Removed redundant checks and account destruction operations.
Cute Animal Picture