Skip to content

Conversation

EperezOk
Copy link

@EperezOk EperezOk commented Aug 1, 2025

What was wrong?

There were some inaccuracies and typos in the docstrings.

How was it fixed?

I've corrected the identified instances.

Cute Animal Picture

Penguins

Copy link
Contributor

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Just needs to be applied to all the forks.

@@ -478,7 +478,7 @@ def account_exists_and_is_empty(state: State, address: Address) -> bool:

def is_account_alive(state: State, address: Address) -> bool:
"""
Check whether is an account is both in the state and non empty.
Check whether an account is both in the state and non-empty.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put back the "both" here. I think it's good to emphasize that both conditions must be true.

@EperezOk
Copy link
Author

EperezOk commented Sep 2, 2025

@SamWilsn all forks have been updated!

@EperezOk EperezOk marked this pull request as ready for review September 2, 2025 05:07
@EperezOk EperezOk requested a review from SamWilsn September 2, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants