chore(ci): switch benchmark fill from evmone to geth#2172
Open
spencer-tb wants to merge 2 commits intoethereum:forks/amsterdamfrom
Open
chore(ci): switch benchmark fill from evmone to geth#2172spencer-tb wants to merge 2 commits intoethereum:forks/amsterdamfrom
spencer-tb wants to merge 2 commits intoethereum:forks/amsterdamfrom
Conversation
2ba5f59 to
161d353
Compare
cfde529 to
f4a6a8d
Compare
f4a6a8d to
330f870
Compare
Contributor
Author
|
CI should pass once the Geth PR is merged! |
fselmo
reviewed
Feb 9, 2026
tox.ini
Outdated
| --gas-benchmark-values 1 \ | ||
| --evm-bin={env:EVM_BIN:evm} \ | ||
| -m "benchmark and not state_test" \ | ||
| -n auto --maxprocesses 10 --dist=loadgroup \ |
Contributor
There was a problem hiding this comment.
why loadgroup in particular? just curious
Contributor
Author
There was a problem hiding this comment.
I don't know how this snuck in there at all, this is duplicating [testenv:benchmark-gas-values]. Removing it all together. Thanks.
Member
|
We also need to set |
Contributor
Author
This should be added in #2170. Thanks. |
RazorClient
pushed a commit
to RazorClient/execution-specs
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Summary
Switches the benchmark test filler from evmone to geth in CI and tox config:
.github/configs/evm.yamlbenchmark entry:evmonetogethtox.inibenchmark testenv default:evmone-t8ntoevmWhy?
Geth will eventually support
--opcode.count(ethereum/go-ethereum#33800) and the EELS stream mode wiring is in place (#2170), giving geth feature parity with evmone for benchmark filling.Switching to geth enables:
🔗 Related Issues or PRs
Requires:
--opcode.countand receipt logs fix✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture