refactor(benchmark): parametrize multi-opcode tests by factory size#2189
Open
CPerezz wants to merge 1 commit intoethereum:forks/amsterdamfrom
Open
refactor(benchmark): parametrize multi-opcode tests by factory size#2189CPerezz wants to merge 1 commit intoethereum:forks/amsterdamfrom
CPerezz wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
…de size Refactor the 3 factory-based bloatnet benchmarks (balance_extcodesize, balance_extcodecopy, balance_extcodehash) to: - Use Create2PreimageLayout instead of manual inline CREATE2 bytecode - Use Conditional for clean STATICCALL error handling - Parametrize by all 6 factory sizes (0.5KB–24KB) from stubs.json, adding the size to each benchmark name - Add 6 factory stub addresses deployed on the bloatnet - Consolidate stubs.json loading to module top (shared by factory and ERC20 tests) Test names now include the bytecode size, e.g.: test_bloatnet_balance_extcodesize[balance_extcodesize-24KB]
Collaborator
|
Hi @CPerezz , thanks a lot for working on this 🙌 I reviewed and realized that PR #2122 overlaps quite a bit with this one, but PR #2122 also includes a broader refactor and some structural changes on top of the same logic. Since that, could we move forward with PR #2122 and cherry picks your commits for the updates of stub files. what do you think |
Contributor
Author
|
Hey @LouisTsai-Csie Will you cherry pick then? I can PR to your branch. but sees cherry-picking might just be easier. LMK if you need anything from my side. But happy to get this commit on top of your stuff. If you prefer me to do a follow-up PR, LMK also and I'll do so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
balance_extcodesize,balance_extcodecopy,balance_extcodehash) to useCreate2PreimageLayoutandConditionalinstead of manual inline CREATE2 bytecode and error handlingtest_bloatnet_balance_extcodesize[balance_extcodesize-24KB])stubs.jsonstubs.jsonloading to module top level (shared by factory and ERC20 tests)