feat(tests): add hash chain test to test parallel execution benchs#2197
Draft
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
Draft
feat(tests): add hash chain test to test parallel execution benchs#2197jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
First test focusing on BALs to verify if a client succesfully implemented parallel execution. This test is not possible to parallel execute if you do not have the BAL.
This is cooked with Claude, have to check some stuff and also verify, hence why this is draft.
Should also figure out where we want to place these tests (@LouisTsai-Csie?)
It will be interesting to see if we target the amount of KECCAK calls to see what setup is the fastest: the most txs? (This needs to schedule many parallel tests)? Or just a few big txs? Tx count which is a multiple of the amount of available threads? Etc etc.
To be verified with e.g. Geth seqential vs full BAL mode. This should yield a significant and noticeable speedup https://github.com/ethereum/go-ethereum/blob/57c631e2a80d35a98a683f61d3e1054dabc7f151/cmd/utils/flags.go#L1051-L1054
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture