Skip to content

feat(tests): add hash chain test to test parallel execution benchs#2197

Draft
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer:bal-benchmarks
Draft

feat(tests): add hash chain test to test parallel execution benchs#2197
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer:bal-benchmarks

Conversation

@jochem-brouwer
Copy link
Member

🗒️ Description

First test focusing on BALs to verify if a client succesfully implemented parallel execution. This test is not possible to parallel execute if you do not have the BAL.
This is cooked with Claude, have to check some stuff and also verify, hence why this is draft.
Should also figure out where we want to place these tests (@LouisTsai-Csie?)

It will be interesting to see if we target the amount of KECCAK calls to see what setup is the fastest: the most txs? (This needs to schedule many parallel tests)? Or just a few big txs? Tx count which is a multiple of the amount of available threads? Etc etc.

To be verified with e.g. Geth seqential vs full BAL mode. This should yield a significant and noticeable speedup https://github.com/ethereum/go-ethereum/blob/57c631e2a80d35a98a683f61d3e1054dabc7f151/cmd/utils/flags.go#L1051-L1054

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant