♻️ refactor(tests): Rename EIP 7708 selfdestruct log to burn#2211
Open
raxhvl wants to merge 2 commits intoethereum:eips/amsterdam/eip-7708from
Open
♻️ refactor(tests): Rename EIP 7708 selfdestruct log to burn#2211raxhvl wants to merge 2 commits intoethereum:eips/amsterdam/eip-7708from
raxhvl wants to merge 2 commits intoethereum:eips/amsterdam/eip-7708from
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-7708 #2211 +/- ##
===========================================================
- Coverage 86.14% 84.14% -2.01%
===========================================================
Files 599 642 +43
Lines 39491 42267 +2776
Branches 3782 4066 +284
===========================================================
+ Hits 34021 35566 +1545
- Misses 4848 5971 +1123
- Partials 622 730 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
ethereum/EIPs#11311 renamed the "Selfdestruct" log topic to "Burn" in the EIP-7708 specification.
The rationale is that "Burn" better describes what happens (ETH is destroyed) rather than how it happens (via the
SELFDESTRUCTopcode). This creates a more consistent API, which reflects the outcome, not the mechanism.What changed
SELFDESTRUCT_TOPICtoBURN_TOPICwith event signatureBurn(address,uint256)emit_selfdestruct_logfunction toemit_burn_log✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.