Skip to content

♻️ refactor(tests): Rename EIP 7708 selfdestruct log to burn#2211

Open
raxhvl wants to merge 2 commits intoethereum:eips/amsterdam/eip-7708from
raxhvl:eips/amsterdam/eip-7708-burn
Open

♻️ refactor(tests): Rename EIP 7708 selfdestruct log to burn#2211
raxhvl wants to merge 2 commits intoethereum:eips/amsterdam/eip-7708from
raxhvl:eips/amsterdam/eip-7708-burn

Conversation

@raxhvl
Copy link
Member

@raxhvl raxhvl commented Feb 14, 2026

🗒️ Description

ethereum/EIPs#11311 renamed the "Selfdestruct" log topic to "Burn" in the EIP-7708 specification.

The rationale is that "Burn" better describes what happens (ETH is destroyed) rather than how it happens (via the SELFDESTRUCT opcode). This creates a more consistent API, which reflects the outcome, not the mechanism.

What changed

  • Rename SELFDESTRUCT_TOPIC to BURN_TOPIC with event signature Burn(address,uint256)
  • Rename emit_selfdestruct_log function to emit_burn_log
  • Update all test references

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@raxhvl raxhvl added the C-test Category: test label Feb 14, 2026
@raxhvl raxhvl changed the title ♻️ refactor(7708): Rename selfdestruct log to burn ♻️ refactor(tests): Rename EIP 7708 selfdestruct log to burn Feb 14, 2026
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (bf16746) to head (50aedc6).
⚠️ Report is 82 commits behind head on eips/amsterdam/eip-7708.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-7708    #2211      +/-   ##
===========================================================
- Coverage                    86.14%   84.14%   -2.01%     
===========================================================
  Files                          599      642      +43     
  Lines                        39491    42267    +2776     
  Branches                      3782     4066     +284     
===========================================================
+ Hits                         34021    35566    +1545     
- Misses                        4848     5971    +1123     
- Partials                       622      730     +108     
Flag Coverage Δ
unittests 84.14% <100.00%> (-2.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant