core: state size metrics #32362
Open
core: state size metrics #32362
+992
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvisa
force-pushed
the
state-size-metrics
branch
from
b9f33e2 to
87e1d82
Compare
core/rawdb/accessors_metadata.go
Outdated
| @@ -187,3 +187,16 @@ func WriteTransitionStatus(db ethdb.KeyValueWriter, data []byte) { | |||
| log.Crit("Failed to store the eth2 transition status", "err", err) | |||
| } | |||
| } | |||
|
|
|||
| // WriteStateSizeMetrics writes the state size metrics to the database | |||
| func WriteStateSizeMetrics(db ethdb.KeyValueWriter, data []byte) { | |||
There was a problem hiding this comment.
I don't think we need to persistent the state size into database.
I would prefer to only keep them in memory.
There was a problem hiding this comment.
If so, we need to iterate the db to calculate the init size for each restart, let me have a test how much time it needs to calculate the init size
|
would it be hard to also add receipts? @shazam8253 can do it otherwise. |
just curious, the receipts were stored mostly in freezer, should also be considered as state size? |
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
This reverts commit 87e1d82. Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
jsvisa
force-pushed
the
state-size-metrics
branch
from
d99afda to
6af49ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 8 more metrics, each for different state category: